Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Tools (from JLayouts) implemented in com_checkin #8854

Conversation

andrepereiradasilva
Copy link
Contributor

Description

In move to normalize the search/filter/order/limit bar (aka searchtools) in all administrator list views, and as other PR's have made for other list component/views, this PR adds JLayouts searchtools to com_checkin only view (checkin) and replacing the old HTML code.

Also:

  • Some HTML code corrected (table blocks order)
  • Resolves bug in pagination when set to "All" (none appeared)
  • Other minor improvements
Isis template
Before patch

com_checkin_isis_before

After patch

com_checkin_isis_after

Hathor template
Before & after patch (no change)

com_checkin_hathor_after

How to test

  1. Edit some content and don't save or close so they are in not checked status
  2. Go to com_checkin ("System" -> "Global check-in").
  3. Apply the patch
  4. Go again to com_checkin ("System" -> "Global check-in").
  5. Test the Search Tools (Search field, ordering and limit).
  6. View hathor template too.

Observations

Suggestions and code revisions are welcome.

Tags

administrator, checkin, search tools, jlayouts, list views, normalization

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jan 7, 2016
@rogerhoen
Copy link

I have tested this item ✅ successfully on aabe76b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

@dgrammatiko
Copy link
Contributor

@andrepereiradasilva can you fix the conflicts here?

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @NLRoosj


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

@andrepereiradasilva
Copy link
Contributor Author

Done

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 68417aa

It works OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

@brianteeman
Copy link
Contributor

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 27, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Feb 19, 2016
@wilsonge
Copy link
Contributor

Merged - thanks!

@wilsonge wilsonge closed this in ac8146a Feb 19, 2016
@andrepereiradasilva andrepereiradasilva deleted the jlayouts-com_checkin-view-checkin branch February 19, 2016 08:50
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants