-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search Tools (from JLayouts) implemented in com_checkin #8854
Closed
andrepereiradasilva
wants to merge
10
commits into
joomla:staging
from
andrepereiradasilva:jlayouts-com_checkin-view-checkin
Closed
Search Tools (from JLayouts) implemented in com_checkin #8854
andrepereiradasilva
wants to merge
10
commits into
joomla:staging
from
andrepereiradasilva:jlayouts-com_checkin-view-checkin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uts-com_checkin-view-checkin
I have tested this item ✅ successfully on aabe76b This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854. |
@andrepereiradasilva can you fix the conflicts here? |
This PR has received new commits. CC: @NLRoosj This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854. |
Done |
I have tested this item ✅ successfully on 68417aa This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854. |
RTC - thanks This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8854. |
Merged - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In move to normalize the search/filter/order/limit bar (aka
searchtools
) in all administrator list views, and as other PR's have made for other list component/views, this PR adds JLayoutssearchtools
to com_checkin only view (checkin) and replacing the old HTML code.Also:
Isis template
Before patch
After patch
Hathor template
Before & after patch (no change)
How to test
Observations
Suggestions and code revisions are welcome.
Tags
administrator, checkin, search tools, jlayouts, list views, normalization