-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joomla Debug Console Improvements #8899
Joomla Debug Console Improvements #8899
Conversation
👍 I'll see if I can test this soon. |
Would be nice if the "visual and informative improvements" also applied to the debug session info |
I have tested this item ✅ successfully on 7fcc15a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
I can change it to pretty-print the session json values (in PHP 5.4+)? ok for you? or are you referring to something else? |
@test success, applied the patch and indeed better layout now This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
@watchfulli-dev please mark as tested https://issues.joomla.org/tracker/joomla-cms/8899 (after login the Test button appears). See https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results |
I have tested this item ✅ successfully on 7fcc15a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
@mbabker in this PR i did some changes in JLogEntry class so it can save the debug backtrace. |
Don't bother. The Framework's Log library is deprecated and all but abandoned at this point. We typehint the PSR-3 logging interface in the Framework where packages support logging and the consensus at the time was Monolog is exponentially better so we weren't rewriting our code to support the interface. |
ok thanks. |
@andrepereiradasilva Yes, something like pretty-print the session json values. Anything would likely look better than the raw JSON values. |
for php 5.4+ indented with colors. older php versions, only colors
This PR has received new commits. CC: @photodude, @watchfulli-dev This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
This PR has received new commits. CC: @photodude, @watchfulli-dev This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
Done, can you test the session part now? |
This PR has received new commits. CC: @photodude, @watchfulli-dev This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
This PR has received new commits. CC: @photodude, @watchfulli-dev This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
This PR has received new commits. CC: @photodude, @watchfulli-dev This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
ok session |
thanks @alikon
This PR has received new commits. CC: @photodude, @watchfulli-dev This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
@alikon thanks for the testing |
Joomla core has a LOT of deprecated messages .... 😟 What we can do is making tabs there for priority and with the totals or by category I think the deprecated warning should stay alone. |
I have tested this item ✅ successfully on f224435 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
I have tested this item ✅ successfully on f224435 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899. |
Ok. i will try do that in other PR. I will also make some other improvements in the new PR. |
RTC then it is! |
Merged - thanks @andrepereiradasilva |
Description
This PR adds some visual and informative improvements to the Joomla Debug Console.
Before PR (Database Queries -> "Call stack" slider)
After PR (Database Queries -> "Call stack" slider)
Before PR (Log Messages)
After PR (Log Messages)
How to test
Observations
Suggestions and improvements are welcome.