Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla Debug Console Improvements #8899

Closed

Conversation

andrepereiradasilva
Copy link
Contributor

Description

This PR adds some visual and informative improvements to the Joomla Debug Console.

Before PR (Database Queries -> "Call stack" slider)

before-callstack

After PR (Database Queries -> "Call stack" slider)

after-callstack

Before PR (Log Messages)

before-logmessages

After PR (Log Messages)

after-logmessages

How to test

  1. Apply this patch.
  2. Turn on the debug in global config and enable the debug system plugin.
  3. Test any page in frontend or administrator and check the "Joomla Debug Console" in the bottom of the page.
  4. Verify the info and visual of "Database Queries" -> "Call stack" slider
  5. Verify the info and visual of "Log Messages"

Observations

Suggestions and improvements are welcome.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jan 13, 2016
@photodude
Copy link
Contributor

👍 I'll see if I can test this soon.

@photodude
Copy link
Contributor

Would be nice if the "visual and informative improvements" also applied to the debug session info

@photodude
Copy link
Contributor

I have tested this item ✅ successfully on 7fcc15a

Definitely a valuable improvement.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@andrepereiradasilva
Copy link
Contributor Author

@photodude

Would be nice if the "visual and informative improvements" also applied to the debug session info

I can change it to pretty-print the session json values (in PHP 5.4+)? ok for you? or are you referring to something else?

@watchfulli-dev
Copy link

@test success, applied the patch and indeed better layout now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@andrepereiradasilva
Copy link
Contributor Author

@watchfulli-dev
Copy link

I have tested this item ✅ successfully on 7fcc15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@andrepereiradasilva
Copy link
Contributor Author

@mbabker in this PR i did some changes in JLogEntry class so it can save the debug backtrace.
I need to made a PR to the log framework repository too, right?

@mbabker
Copy link
Contributor

mbabker commented Jan 15, 2016

Don't bother. The Framework's Log library is deprecated and all but abandoned at this point. We typehint the PSR-3 logging interface in the Framework where packages support logging and the consensus at the time was Monolog is exponentially better so we weren't rewriting our code to support the interface.

@andrepereiradasilva
Copy link
Contributor Author

ok thanks.

@photodude
Copy link
Contributor

@andrepereiradasilva Yes, something like pretty-print the session json values. Anything would likely look better than the raw JSON values.

for php 5.4+ indented with colors. older php versions, only colors
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@andrepereiradasilva
Copy link
Contributor Author

Done, can you test the session part now?

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@alikon
Copy link
Contributor

alikon commented Jan 16, 2016

ok session
ok call stack
ko Log messages
gives different result items

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @photodude, @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@andrepereiradasilva
Copy link
Contributor Author

@alikon thanks for the testing
"ok Log messages" now?

@alikon
Copy link
Contributor

alikon commented Jan 17, 2016

if we can have a subtotal for each logged category messages (not only for deprecated) should be OK
test administration plugins system debug

@andrepereiradasilva
Copy link
Contributor Author

Joomla core has a LOT of deprecated messages .... 😟

What we can do is making tabs there for priority and with the totals
ex: CRITICAL xx || WARNING xx || INFO xx || DEBUG xx

or by category
ex: Deprecated xx || Databasequery xx || etc xx

I think the deprecated warning should stay alone.

@810
Copy link
Contributor

810 commented Jan 17, 2016

I have tested this item ✅ successfully on f224435


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@photodude
Copy link
Contributor

I have tested this item ✅ successfully on f224435

I do agree that we should have a summary subtotal for each logged category in the log section.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8899.

@andrepereiradasilva
Copy link
Contributor Author

Ok. i will try do that in other PR.
This one has already lot of changes and is RTC.

I will also make some other improvements in the new PR.

@dgrammatiko
Copy link
Contributor

RTC then it is!

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 17, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Jan 26, 2016
@wilsonge wilsonge closed this in be1cecc Jan 26, 2016
@wilsonge
Copy link
Contributor

Merged - thanks @andrepereiradasilva

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 26, 2016
@andrepereiradasilva andrepereiradasilva deleted the improve-debugger branch January 27, 2016 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants