Double icon for images in the editor toolbar #9266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the plugin buttons that were at the bottom of the editor as been moved inside the editor toolbar, there are two double icons for images: one of TinyMCE and one Joomla. This patch changes the icon of Joomla Image button, to distinguish it from the other one.
|
Makes sense to differentiate them indeed. |
|
I have tested this item ✅ successfully on a6781fa This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9266. |
|
@test: patch tested, working fine, the two icons are differentiated This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9266. |
|
@stellainformatica |
|
I have tested this item ✅ successfully on a6781fa This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9266. |
|
I guesss this can go in 3.5.0 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9266. |
wilsonge
added a commit
that referenced
this pull request
Mar 1, 2016
Double icon for images in the editor toolbar
|
Merged - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
After the plugin buttons that were at the bottom of the editor as been moved inside the editor toolbar, there are two double icons for images: one of TinyMCE and one Joomla.
This patch changes the icon of Joomla Image button, to distinguish it from the other one.