Added drag and drop functionality to the item ordering of featured articles (Ref #8138) #9564

nishadi · 2016-03-24T11:13:37Z

Pull Request for Issue #8138

Summary of Changes

Added ordering Heading button
Added sort-able drag and drop button with drag and drop functionality
Added save ordering functionality to save the ordering when the items are sorted with drag and drop

Testing Instructions

Go to Back end > Content > Articles
Can sort the article items by drag and drop
Go to Back end > Content > Featured Articles
Can not sort the article items by drag and drop
Apply the patch
Go to Back end > Content > Featured Articles
Now the view shows the drag and drop functionality

…ticles

brianteeman · 2016-03-24T11:54:09Z

This seems to work but it is a little confusing (to me at least) as the number doesnt change on screen until after a page refresh

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

andrepereiradasilva · 2016-03-24T15:14:08Z

administrator/components/com_content/views/featured/tmpl/default.php

+	JHtml::_('sortablelist.sortable', 'articleList', 'adminForm', strtolower($listDirn), $saveOrderingUrl);
+}
+
+$assoc = JLanguageAssociations::isEnabled();


hi. why is this ($assoc = JLanguageAssociations::isEnabled();) added here?

lunalars · 2016-03-24T18:27:18Z

I think the column "Ordering" should be removed completely (like at articles).

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

nishadi · 2016-03-25T03:53:11Z

I will update the PR according to the given feedback.

JoshJourney · 2016-03-25T05:11:55Z

Subscribed. Let us know when this PR is updated.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

Webdongle · 2016-03-25T11:40:34Z

I have tested this item 🔴 unsuccessfully on 8da42a6

Clicking the 'Ordering' column changes the sort by field correctly. But clicking the 'arrow' column doesn't change the sort by field correctly which prevents the drag/drop from working.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

joomla-cms-bot · 2016-03-25T16:49:47Z

This PR has received new commits.

CC: @Webdongle

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

nishadi · 2016-03-25T16:52:30Z

I have updated the PR removing the ordering column as suggested and now the featured article listing looks exactly like the article listing.
Need clarifications on updating and normalization of the default ordering in featured articles.

Thanks

Webdongle · 2016-03-25T17:32:58Z

I have tested this item ✅ successfully on 1c6d138

Excellent. Acts exactly the same as the Articles page. Front end Featured Articles displays according to order in the featured drag/drop screen.

Full Success

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

lunalars · 2016-03-25T17:57:18Z

I have tested this item ✅ successfully on 1c6d138

Yup, as webdongle said.
Thanks!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

andrepereiradasilva · 2016-03-25T18:13:27Z

@nishadi it seems fine now. thanks for your contributions.

I would make two modifications:

remove the sortable-group-id="<?php echo $item->catid; ?>" to allow to order across multiple categories. We are talking here about feature articles that can be across categories, right?
In the list filter xml i would put the fp.ordering ordering options in first place because it's the first column. That would normalize with the other table list view.

UPDATE see the 2 patches i made to your repository, if all ok for you, accept them.

allow ordering across categories

joomla-cms-bot · 2016-03-26T05:25:38Z

This PR has received new commits.

CC: @lunalars, @Webdongle

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

ordering options order like columns order

joomla-cms-bot · 2016-03-26T05:26:27Z

This PR has received new commits.

CC: @lunalars, @Webdongle

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

nishadi · 2016-03-26T05:29:07Z

@andrepereiradasilva
Thanks you for the PRs and clarifications. I have accepted them.

andrepereiradasilva · 2016-03-26T11:04:32Z

@Webdongle sorry? my patch only removed the limitation do order between multiple categories, as it should be. Before the patch has limited to order with drag and drop in one category, after the patch you can order with drag and drop between several categories.

See ab1d799

Are you testing with this settings in the feature menu item?

Webdongle · 2016-03-26T11:22:44Z

@andrepereiradasilva when I tested before your pr was added the articles displayed correctly in the front end. It could have been the removal of the 'Ordering' column'. If @nishadi checks by removing each edit and setting the menu item 1 column then that should show which broke it

Also point of testing etiquette ... although it;s not your patch you have added to it. Therefore should your test results in the tracker be discounted ? I mean no disrespect by that question.

andrepereiradasilva · 2016-03-26T11:28:35Z

@andrepereiradasilva when I tested before your pr was added the articles displayed correctly in the front end. It could have been the removal of the 'Ordering' column'. If @nishadi checks by removing each edit and setting the menu item 1 column then that should show which broke it

ok, so no problem with my patch them.

Also point of testing etiquette ... although it;s not your patch you have added to it. Therefore should your test results in the tracker be discounted ? I mean no disrespect by that question.

Actually it makes perfectly sense. If i contributed to the PR i shouldn't mark test results. Thank you for the warning. I removed my test result.
I guess i need some lessons of "testing etiquette" 😉

Webdongle · 2016-03-26T12:15:10Z

@andrepereiradasilva

Same result with

There is a Category order in the menu item edit screen and imho removing sortable-group-id="catid; ?>" messed up the way the Component reads the menu item settings.

Thae Category order Setting in the menu item edit screen may be redundant (I have yet to test) but methinks it is required. Because the webmaster may wish to display Category order first then other order per category.
e.g.

Cats
--- Moggies
--- Persians

Dogs
--- Alsations
--- Terrier

Therefore removing sortable-group-id="catid; ?>" breaks the usability in any case. And that change should be reverted.

This is not a 'knock' at your efforts. ... they are appreciated. Just that I test/post in a 'matter of fact' way without emotion.

andrepereiradasilva · 2016-03-26T12:21:43Z

@Webdongle
Check your backend column order (you are ordering by title there). You should be ordering by order.

andrepereiradasilva · 2016-03-26T13:40:48Z

@Webdongle

There is a Category order in the menu item edit screen and imho removing sortable-group-id="catid; ?>" messed up the way the Component reads the menu item settings.

That "Category order" option is for, when you have feature articles in several categories, order by that "Category order" first and then by "Article order" (the next field).

You can see that behaviour in https://github.com/joomla/joomla-cms/blob/staging/components/com_content/models/featured.php#L124-L130

My change does not change that. In fact, i made the change to allow the use of "Category order = No order" when you have feature articles in multiple categories, like it was before this PR.

Webdongle · 2016-03-26T14:10:02Z

I have tested this item ✅ successfully on 75cba61

Retested and Full Success

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

Webdongle · 2016-03-26T14:19:43Z

@andrepereiradasilva

Yep ... that was it had wrong sort column. Have deleted my previous test result and added a successful one. Thanks for finding my PEBKAC

I know what the "Category order" option is for. Had to have breakfast before I had chance to test. I changed the category of one of the featured articles ... applying the patch had no adverse affect.

andrepereiradasilva · 2016-03-30T09:51:32Z

@lunalars can you test this again after latest changes so it has to successfully tests.

lunalars · 2016-03-30T15:03:05Z

I have tested this item ✅ successfully on 75cba61

Tested on staging with test content: changed ordering is saved and articles are displayed accordingly.

(And sorry for being late)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

nishadi · 2016-03-30T15:20:17Z

Thanks for testing the PR

brianteeman · 2016-03-31T07:46:01Z

RTC - thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.}

rdeutz · 2016-05-02T06:10:35Z

@nishadi cloud you please check the merge conflicts, thanks

Kubik-Rubik · 2016-05-08T13:04:45Z

Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. To save time I have created a new Pull Request from your code and am closing this here.

Check #10313

… (#10313) * Added drag and drop functionality to the item ordering of featured articles * Removed ordering column from featured articles * ordering options order like columns order * allow sorting across categories * Merge branch 'staging' of https://github.com/nishadi/joomla-cms into nishadi-staging Fixed Conflicts: # administrator/components/com_content/views/featured/tmpl/default.php * Updated with changes from #10062

Added drag and drop functionality to the item ordering of featured ar…

8da42a6

…ticles

joomla-cms-bot added the PR-staging label Mar 24, 2016

nishadi mentioned this pull request Mar 24, 2016

Featured Items ordering is not set by drag and drop like articles and categories #8138

Closed

andrepereiradasilva reviewed Mar 24, 2016
View reviewed changes

Removed ordering column from featured articles

1c6d138

andrepereiradasilva and others added 3 commits March 25, 2016 18:22

ordering options order like columns order

17bc905

allow sorting across categories

d87808b

Merge pull request #2 from andrepereiradasilva/patch-8

ab1d799

allow ordering across categories

Merge pull request #1 from andrepereiradasilva/patch-7

75cba61

ordering options order like columns order

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 31, 2016

rdeutz added this to the Joomla! 3.6.0 milestone Apr 13, 2016

Kubik-Rubik mentioned this pull request May 8, 2016

Nishadi Drag and Drop functionality for Featured Articles - Fixes #9564 #10313

Merged

Kubik-Rubik closed this May 8, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 8, 2016

brianteeman removed this from the Joomla 3.6.0 milestone May 9, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added drag and drop functionality to the item ordering of featured articles (Ref #8138) #9564

Added drag and drop functionality to the item ordering of featured articles (Ref #8138) #9564

nishadi commented Mar 24, 2016

brianteeman commented Mar 24, 2016

andrepereiradasilva Mar 24, 2016

lunalars commented Mar 24, 2016

nishadi commented Mar 25, 2016

JoshJourney commented Mar 25, 2016

Webdongle commented Mar 25, 2016

joomla-cms-bot commented Mar 25, 2016

nishadi commented Mar 25, 2016

Webdongle commented Mar 25, 2016

lunalars commented Mar 25, 2016

andrepereiradasilva commented Mar 25, 2016

joomla-cms-bot commented Mar 26, 2016

joomla-cms-bot commented Mar 26, 2016

nishadi commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

Webdongle commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

Webdongle commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

Webdongle commented Mar 26, 2016

Webdongle commented Mar 26, 2016

andrepereiradasilva commented Mar 30, 2016

lunalars commented Mar 30, 2016

nishadi commented Mar 30, 2016

brianteeman commented Mar 31, 2016

rdeutz commented May 2, 2016

Kubik-Rubik commented May 8, 2016

Added drag and drop functionality to the item ordering of featured articles (Ref #8138) #9564

Added drag and drop functionality to the item ordering of featured articles (Ref #8138) #9564

Conversation

nishadi commented Mar 24, 2016

Summary of Changes

Testing Instructions

brianteeman commented Mar 24, 2016

andrepereiradasilva Mar 24, 2016

Choose a reason for hiding this comment

lunalars commented Mar 24, 2016

nishadi commented Mar 25, 2016

JoshJourney commented Mar 25, 2016

Webdongle commented Mar 25, 2016

joomla-cms-bot commented Mar 25, 2016

nishadi commented Mar 25, 2016

Webdongle commented Mar 25, 2016

lunalars commented Mar 25, 2016

andrepereiradasilva commented Mar 25, 2016

joomla-cms-bot commented Mar 26, 2016

joomla-cms-bot commented Mar 26, 2016

nishadi commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

Webdongle commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

Webdongle commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

andrepereiradasilva commented Mar 26, 2016

Webdongle commented Mar 26, 2016

Webdongle commented Mar 26, 2016

andrepereiradasilva commented Mar 30, 2016

lunalars commented Mar 30, 2016

nishadi commented Mar 30, 2016

brianteeman commented Mar 31, 2016

rdeutz commented May 2, 2016

Kubik-Rubik commented May 8, 2016