Fix for insertid not returning what it's supposed to #9610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on e5a9742 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9610. |
| { | ||
| $this->connect(); | ||
|
|
||
| return $this->setQuery('SELECT LAST_INSERT_ID() AS id')->execute()->fetchObject()->id; |
There was a problem hiding this comment.
Two comments:
- Perhaps here you can use JQuery (for a cleaner approach):
$query = $this->getQuery(true)->select('LAST_INSERT_ID()'); - I guess a shorter call would be:
(int) $this->setQuery($query)->loadResult();
so:
public function insertid()
{
$query = $this->getQuery(true)->select('LAST_INSERT_ID()');
return (int) $this->setQuery($query)->loadResult();
}
|
I found the root cause of this and committed the fix after getting it approved my @mbabker |
wilsonge
added a commit
that referenced
this pull request
Mar 26, 2016
|
Well done. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issues #9534, #9572 and #9582.
Summary of Changes
Same as #9601 but code has been moved to the MySQL-specific PDO driver.
Testing Instructions
You need a site which fails under the circumstances described in the issues above. The easiest is probably #9572. Apply the PR then check that the issue is resolved.