Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend login, remove the dot in link #9869

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

Summary of Changes

very simple PR just to remove the dot in backend login panel "Go to site home page." link.

Testing Instructions

Go to the bottom of the backend login screen, there in a "Go to site home page." link, after patch the dot is removed.
Or just check code difference.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Apr 12, 2016
@brianteeman
Copy link
Contributor

Personally its a sentence so needs the .

@andrepereiradasilva
Copy link
Contributor Author

A link with a dot? How about just "View Site" like when you're logged in?

@brianteeman
Copy link
Contributor

@chrisdavenport any thoughts?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9869.

@chrisdavenport
Copy link
Contributor

Technically, it's a complete sentence in its own right, so it should have a full stop. But in this case it's being used purely as link text which just happens to be a full English sentence. As a link it certainly does look odd with the full stop, so I tend to agree with @andrepereiradasilva and I think it should be removed.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5558da9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9869.

@brianteeman
Copy link
Contributor

RTC using @chrisdavenport as a successful test ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9869.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 12, 2016
@brianteeman brianteeman added this to the Joomla 3.5.2 milestone Apr 12, 2016
@rdeutz rdeutz merged commit f7ee6d0 into joomla:staging Apr 12, 2016
@andrepereiradasilva andrepereiradasilva deleted the patch-14 branch April 12, 2016 20:59
@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants