Vote button missing default styling in 3.5.1 #9966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 7, 2016 15:48
This reverts commit 08789d9.
|
i can't see any visual change in protostar after PR. But i can see the new css class. |
|
Is this meant for future Joomla versions in case a new Bootstrap version is bundled? Because |
|
This PR is wrong as it is using a non existent class. That why @andrepereiradasilva couldn't see any change. Check the bootstrap docs :) |
|
sorry my bad.. I'm so used to bs3 never dawned on me bs2 would change the name of that single button class when all the rest are the same LOL... |
|
Sorry but closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
added btn-default to the "rate" button to provide default bootstrap styling in 3.5.1
Testing Instructions
create a article that has voting turned on.
inspect the "rate" button. You'll see that there is no default styling.
install the patch and you will see the styling added... and button will take on the default color style for
buttons.