Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Get tests running in the respective packages, independently #4

Closed
9 of 36 tasks
eddieajau opened this issue Feb 28, 2013 · 21 comments
Closed
9 of 36 tasks

Get tests running in the respective packages, independently #4

eddieajau opened this issue Feb 28, 2013 · 21 comments

Comments

@eddieajau
Copy link
Contributor

See the Date package for a good example.

  • phpunit.xml.dist needs to be copied from the Date package into each package and test the running of tests.
  • bootstrap.php needs to be copied fromDate\Tests` to the corresponding package you are working on.
  • Each test file needs to be namepaced, for example, for the Date package, the namespace is \Joomla\Date\Tests.

Complete:

  • Application
  • Archive
  • Cache
  • Controller
  • Crypt
  • Data
  • Database
  • Date
  • DI
  • Event
  • Facebook
  • Filesystem
  • Filter
  • Form
  • Github
  • Google
  • Http
  • Image
  • Input
  • Keychain
  • Language
  • Ldap
  • Linkedin
  • Log
  • Model
  • Oauth1
  • Oauth2
  • Profiler
  • Registry
  • Router
  • Session
  • String
  • Twitter
  • Uri
  • Utilities
  • View
@eddieajau
Copy link
Contributor Author

Database done. I've put in a new Joomla/Test package. It was just getting a bit crazy to fit up TestReflection and also the mock builders. I'm assuming we can only include that if "dev" is set. Anyway, see what you think. ONly took 6 hours straight to patch it all up.

@eddieajau
Copy link
Contributor Author

Utilities and Registry done.

@eddieajau
Copy link
Contributor Author

Data package done.

@eddieajau
Copy link
Contributor Author

String package done.

@dongilbert
Copy link
Contributor

Working on Controller

@dongilbert
Copy link
Contributor

ehh - maybe scratch that. Not sure what to do about it's dependency on JFactory. :(

So, until we refactor the code, it's kind of not possible to make these tests separate.

(and I thought I was picking an easy one)

@mbabker
Copy link
Contributor

mbabker commented Mar 2, 2013

Attempting Model (maybe I got the easy one 😉 )

@mbabker
Copy link
Contributor

mbabker commented Mar 2, 2013

Working Application

@mbabker
Copy link
Contributor

mbabker commented Mar 2, 2013

Http's done. I actually finished one... LOL

@eddieajau
Copy link
Contributor Author

Whoot! Another one bits the dust.

@mbabker
Copy link
Contributor

mbabker commented Mar 3, 2013

Uri done.

@dongilbert
Copy link
Contributor

I'll be working on the following packages tonight:

Google
Image

@mbabker
Copy link
Contributor

mbabker commented Oct 22, 2013

Where do we stand with this one?

@dongilbert
Copy link
Contributor

We'll see after we tag beta3 and try to run composer install; phpunit in each directory. :)

@dongilbert
Copy link
Contributor

IIRC, the only remaining conflicts were due to the inability of composer to resolve dependencies.

@wilsonge
Copy link
Contributor

So much phpcs to be fixed tho :P

@dongilbert
Copy link
Contributor

Jump on it bro.

@mbabker
Copy link
Contributor

mbabker commented Oct 22, 2013

Perfect low hanging fruit for a student wanting to get their feet wet in
the PHP world :-P

On Tue, Oct 22, 2013 at 5:08 PM, George Wilson notifications@github.comwrote:

So much phpcs to be fixed tho :P


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-26858061
.

@dongilbert
Copy link
Contributor

Exactly @mbabker. It's not that I don't want to do it (I do, in fact, want to), but it's a great opportunity for those who want to to build some cred and experience. Fixing CS is how I got to most LOC touched on the FW.

@wilsonge
Copy link
Contributor

haha. If I have time I'll get on it. Still getting screwed by my essay at
the moment that's due on Friday + a couple of job applications I need to
rewrite my CV for due next week. And my need to learn a load of electronics
I claimed I already knew about for my final year project so I got a good
project haha.

Although just saying I was at a careers fair today - where I was scoffed
for learning PHP because Java is the language of professionals apparently :P

On 22 October 2013 23:14, Don Gilbert notifications@github.com wrote:

Exactly @mbabker https://github.com/mbabker. It's not that I don't want
to do it (I do, in fact, want to), but it's a great opportunity for those
who want to to build some cred and experience. Fixing CS is how I got to
most LOC touched on the FW.


Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-26859241
.

@eddieajau
Copy link
Contributor Author

I'm going to close this one and if there are any problems we can fix problems individually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants