Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Clean up Form Package #238

Merged
merged 3 commits into from
Oct 22, 2013
Merged

Clean up Form Package #238

merged 3 commits into from
Oct 22, 2013

Conversation

dongilbert
Copy link
Contributor

This PR cleans up the Form package to remove some CMS remnants.

  • Remove JFactory from Form class.
  • Remove JFactory from Rule\Email. Remove unique check, because it's for the CMS.
  • Removing SQL field type. Create a custom field type instead.
  • Remove Factory from Field\Timezone. Fix usage of JHtml.
  • Remove unused tests.
  • Remove ComboBox field type. Not used anywhere (not even in the CMS) and requires media.
  • Remove password strength meter. Requires media.
  • More cleanup

Thanks @mbabker for helping answer some questions on this. 馃憤

Remove JFactory from Rule\Email. Remove unique check, because it's for the CMS.

Removing SQL field type. Create a custom field type instead.

Remove Factory from Field\Timezone. Fix usage of JHtml.

Remove tests.

Remove ComboBox field type. Unused and requires media.

More cleanup
@dongilbert dongilbert mentioned this pull request Oct 18, 2013
14 tasks
@dongilbert
Copy link
Contributor Author

Doing a bit more work on this.

@dongilbert
Copy link
Contributor Author

This latest PR removes all the add*Path and load*Type methods from the Form class that were just proxies to the identically named methods in FormHelper. I also moved around the UT's and created a test class for the FormHelper.

mbabker added a commit that referenced this pull request Oct 22, 2013
@mbabker mbabker merged commit 8562f00 into joomla:staging Oct 22, 2013
@dongilbert dongilbert deleted the bugfix-JForm branch October 22, 2013 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants