Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Remove Factory usage from the Session package #241

Merged
merged 3 commits into from
Oct 22, 2013
Merged

Remove Factory usage from the Session package #241

merged 3 commits into from
Oct 22, 2013

Conversation

dongilbert
Copy link
Contributor

This PR removes all usage of the global Factory class from the Session package.

Specifically, it:

  • Moves configuration for Storage Drivers into the constructor
  • Requires the injection of a db parameter when using the Database Storage Driver.
  • Moves getFormToken and checkToken into AbstractWebApplication, including the tests.

@dongilbert dongilbert mentioned this pull request Oct 22, 2013
14 tasks
@@ -1270,6 +1270,27 @@ public function testIsSSLConnection()
}

/**
* Test getFormToken
*
* @covers JSession::getFormToken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers statement needs updating

@dongilbert
Copy link
Contributor Author

@mbabker Updated. Good catch.

eddieajau added a commit that referenced this pull request Oct 22, 2013
Remove Factory usage from the Session package
@eddieajau eddieajau merged commit 2986a89 into joomla:staging Oct 22, 2013
@dongilbert dongilbert deleted the feature-SessionJFactoryRemoval branch October 22, 2013 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants