Merge pull request #717 from pasamio/test-improvements

Test Improvement from eBay Content repository

tests/includes/JoomlaDatabaseTestCase.php

@@ -510,22 +510,24 @@ public function getMockSession($options = array())
 
 		return JSessionGlobalMock::create($this, $options);
 	}
-	
+
 	/**
 	 * Gets a mock web object.
 	 *
-	 * @return  JWeb
+	 * @param   array  $options  A set of options to configure the mock.
+	 *
+	 * @return  JApplicationWeb
 	 *
 	 * @since   12.1
 	 */
-	public function getMockWeb()
+	public function getMockWeb($options = array())
 	{
 		// Load the real class first otherwise the mock will be used if jimport is called again.
 		require_once JPATH_PLATFORM . '/joomla/application/web.php';
-	
+
 		// Load the mock class builder.
-		require_once JPATH_TESTS . '/includes/mocks/JWebMock.php';
-	
-		return JWebGlobalMock::create($this);
+		require_once JPATH_TESTS . '/includes/mocks/JApplicationWebMock.php';
+
+		return JApplicationWebGlobalMock::create($this, $options);
 	}
 }

tests/includes/JoomlaTestCase.php

@@ -451,22 +451,24 @@ public function getMockSession($options = array())
 
 		return JSessionGlobalMock::create($this, $options);
 	}
-	
+
 	/**
 	 * Gets a mock web object.
 	 *
-	 * @return  JWeb
+	 * @param   array  $options  A set of options to configure the mock.
+	 *
+	 * @return  JApplicationWeb
 	 *
 	 * @since   12.1
 	 */
-	public function getMockWeb()
+	public function getMockWeb($options = array())
 	{
 		// Load the real class first otherwise the mock will be used if jimport is called again.
 		require_once JPATH_PLATFORM . '/joomla/application/web.php';
-	
+
 		// Load the mock class builder.
-		require_once JPATH_TESTS . '/includes/mocks/JWebMock.php';
-	
-		return JWebGlobalMock::create($this);
+		require_once JPATH_TESTS . '/includes/mocks/JApplicationWebMock.php';
+
+		return JApplicationWebGlobalMock::create($this, $options);
 	}
 }

tests/includes/mocks/JWebMock.php → tests/includes/mocks/JApplicationWebMock.php

@@ -11,31 +11,32 @@
 require_once __DIR__ . '/JSessionMock.php';
 
 /**
- * Mock class for JWeb.
+ * Mock class for JApplicationWeb.
  *
  * @package  Joomla.UnitTest
  * @since    12.1
  */
-class JWebGlobalMock
+class JApplicationWebGlobalMock
 {
 	/**
-	 * Creates and instance of the mock JWeb object.
+	 * Creates and instance of the mock JApplicationWeb object.
 	 *
-	 * @param   object  $test  A test object.
+	 * @param   object  $test     A test object.
+	 * @param   array   $options  A set of options to configure the mock.
 	 *
 	 * @return  object
 	 *
 	 * @since   11.3
 	 */
-	public static function create($test)
+	public static function create($test, $options = array())
 	{
 		// Set expected server variables.
 		if (!isset($_SERVER['HTTP_HOST']))
 		{
 			$_SERVER['HTTP_HOST'] = 'localhost';
 		}
 
-		// Collect all the relevant methods in JWeb (work in progress).
+		// Collect all the relevant methods in JApplicationWeb (work in progress).
 		$methods = array(
 			'get',
 			'getDocument',
@@ -45,7 +46,7 @@ public static function create($test)
 
 		// Create the mock.
 		$mockObject = $test->getMock(
-			'JWeb',
+			'JApplicationWeb',
 			$methods,
 			// Constructor arguments.
 			array(),
@@ -55,15 +56,22 @@ public static function create($test)
 			true
 		);
 
-		// Mock calls to JWeb::getDocument().
+		// Mock calls to JApplicationWeb::getDocument().
 		$mockObject->expects($test->any())->method('getDocument')->will($test->returnValue(JDocumentGlobalMock::create($test)));
-		
-		// Mock calls to JWeb::getDocument().
+
+		// Mock calls to JApplicationWeb::getLanguage().
 		$mockObject->expects($test->any())->method('getLanguage')->will($test->returnValue(JLanguageGlobalMock::create($test)));
-
-		// Mock calls to JWeb::getSession().
-		$mockObject->expects($test->any())->method('getSession')->will($test->returnValue(JSessionGlobalMock::create($test)));
+
+		// Mock a call to JApplicationWeb::getSession().
+		if (isset($options['session']))
+		{
+			$mockObject->expects($test->any())->method('getSession')->will($test->returnValue($options['session']));
+		}
+		else
+		{
+			$mockObject->expects($test->any())->method('getSession')->will($test->returnValue(JSessionGlobalMock::create($test)));
+		}
 
 		return $mockObject;
 	}
-}
+}

tests/includes/mocks/JSessionMock.php

@@ -37,14 +37,14 @@ public function getOption($name, $default = null)
 	}
 
 	/**
-	 * Creates an instance of the mock JDatabase object.
+	 * Creates an instance of the mock JSession object.
 	 *
-	 * @param   object  $test    A test object.
-	 * @param   array   $config  An array of optional configuration values.
-	 *                           getId : the value to be returned by the mock getId method
-	 *                           get.user.id : the value to assign to the user object id returned by get('user')
-	 *                           get.user.name : the value to assign to the user object name returned by get('user')
-	 *                           get.user.username : the value to assign to the user object username returned by get('user')
+	 * @param   object  $test     A test object.
+	 * @param   array   $options  An array of optional configuration values.
+	 *                            getId : the value to be returned by the mock getId method
+	 *                            get.user.id : the value to assign to the user object id returned by get('user')
+	 *                            get.user.name : the value to assign to the user object name returned by get('user')
+	 *                            get.user.username : the value to assign to the user object username returned by get('user')
 	 *
 	 * @return  object
 	 *
@@ -110,7 +110,7 @@ public static function create($test, $options = array())
 	}
 
 	/**
-	 * Mocking the quote method.
+	 * Mocking the get method.
 	 *
 	 * @param   string  $key  The key to get.
 	 *
@@ -130,6 +130,7 @@ public function mockGet($key)
 				$user->id = (int) self::getOption('get.user.id', 0);
 				$user->name = self::getOption('get.user.name');
 				$user->username = self::getOption('get.user.username');
+				$user->guest = (int) self::getOption('get.user.guest', 1);
 
 				return $user;
 		}