This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Fix JForm::load() not replacing form field in same location (Issue #129) #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to replace the old definition. Duplicate fields will now remain in their original location rather than being moved to the end of the document.
|
What are the odds of getting you to write unit tests for this? |
|
@LouisLandry what are the odds of me getting to do GSoC with you guys? The two are about the same :D |
…h replacement the first n name fields are in the same as those of the replaced form where n is the length of the replaced form.
|
Aaron, |
chdemko
added a commit
that referenced
this pull request
Apr 13, 2012
Fix JForm::load() not replacing form field in same location (Issue #129)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code causes JForm to replace fields in place when a new definition is loaded to replace the old definition. Duplicate fields will now remain in their original location rather than being moved to the end of the document.