This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Form Package: db->error, Exception/JText modifications #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: throw exception. | ||
|
|
||
| return $default; | ||
| throw new RuntimeException('XML is not an instance of JXMLElement'); |
There was a problem hiding this comment.
I would throw this as an UnexpectedValueException like this:
throw new UnexpectedValueException(sprint('%s::getFieldAttribute `xml` is not an instance of JXMLElement', get_class($this)));
That way it's easier for the developer to home in on where the error is. Ditto for the other cases.
|
Really good job overall Amy, just a bit of nuance to fix. |
|
All right, I think I have this one updated for @eddieajau 's feedback. Thanks Andrew. |
|
Merged. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.