This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Fix and improve the docblocks in the legacy folder. #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddieajau
added a commit
that referenced
this pull request
Apr 8, 2012
Fix and improve the docblocks in the legacy folder.
|
Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides changing the subpackage tags to match the folders the biggest change is to undeprecated the protected class members that start with an underscore.
Those hints - without offering a real alternative - only confuse developers, I don't think we'll want to do a change like this in the legacy folder anyways since those classes are eventually gonna be removed or moved to the CMS.