This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Change registerPrefix and registerNamespace to LIFO #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes a ton of sense, and I would consider it an oversight on my part that it doesn't already behave that way.. 👍 That being said, I'd like to leave it open for a day or so to see if we get any strong dissenting opinions. |
|
+1 |
|
+1 solves gigantic practical problems. |
LouisLandry
added a commit
that referenced
this pull request
Dec 5, 2012
Change registerPrefix and registerNamespace to LIFO
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering a prefix or namespace, the last path registered should be the first path searched. This would make overriding classes MUCH easier.