This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
JDocumentRenderer tests skipped #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JDocumentRendererAtom and JDocumentRendererRSS classes are too tightly coupled for good testing right now, so I marked the tests as skipped with a todo to come back after breaking more dependencies in the code.
LouisLandry
added a commit
that referenced
this pull request
Jun 10, 2011
JDocumentRenderer tests skipped
LouisLandry
added a commit
that referenced
this pull request
Jul 23, 2011
JDocumentRenderer tests skipped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JDocumentRendererAtom and JDocumentRendererRSS classes are too tightly coupled
for good testing right now, so I marked the tests as skipped with a todo to come back after
breaking more dependencies in the code.
I basically punted on these tests, after doing a minor bit of code cleanup. They're too tightly coupled with too long of a chain of static method calls to be able to test as a block right now. So I marked the tests as skipped, and left a TODO to revisit them after we've broken a few more layers of dependency.