Documentation - Variable types #569
Conversation
|
Unit testing complete. There were 0 failures and 0 errors from 1872 tests and 11090 assertions. |
| * @param string $control_name Control name | ||
| * @param string $name Field name | ||
| * @param string $value The date value | ||
| * @param JSimpleXMLElement &$node JSimpleXMLElement node object containing the settings for the element |
There was a problem hiding this comment.
I believe this should be JXMLElement instead of JSimpleXMLElement
There was a problem hiding this comment.
Possibly. I'd have to get an environment set up where I'm calling JElement instances to accurately figure it out, but I'm hoping that in this instance (and the other few instances that are "properly" commented), the comment stating it's a JSimpleXMLElement is correct.
There was a problem hiding this comment.
I believe the others are also incorrect - I just don't wanted to spam ;)
JSimpleXMLElement has been deprecated and the functionality is now covered by JXMLElement which extends SimpleXMLElement (the PHP one).
|
Build triggered by changes to the head. Unit testing complete. There were 0 failures and 0 errors from 1872 tests and 11090 assertions. |
|
Build triggered by changes to the head. Unit testing complete. There were 0 failures and 0 errors from 1872 tests and 11090 assertions. |
Documentation - Variable types
|
Thanks Michael. That's awesome work. |
To better help developers, I've started reviewing the "undefined methods" inspection on PhpStorm and trying to update docblocks to more accurately reflect what each parameter type is and what is being returned. Most of these changes are based on what is commented in the docblock or based on the instance type that is being returned.