Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Update JHtmlForm::token() test #613

Merged
merged 1 commit into from
Dec 7, 2011
Merged

Update JHtmlForm::token() test #613

merged 1 commit into from
Dec 7, 2011

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Dec 6, 2011

Update the test to mock the session due to a unit test failure locally, and use getFormToken in the test as well.

@joomla-jenkins
Copy link

Unit testing complete. There were 0 failures and 0 errors from 1876 tests and 11095 assertions.
Checkstyle analysis reported 254 warnings and 0 errors.

@elkuku
Copy link
Contributor

elkuku commented Dec 6, 2011

This fixes the UT error on my side too.
Not sure why they would only appear "locally", but it works :)

@mbabker
Copy link
Contributor Author

mbabker commented Dec 6, 2011

Well, they weren't showing up from Jenkins reports. So, obviously, he's
got some super secret squirrelly stuff going on to keep from getting that
failure ;-)

On 12/7/11 1:29 AM, "Nikolai Plath"
<reply+i-2459345-87575b293c399da6f106104af839bb02795b25c5-368545@reply.gith
ub.com> wrote:

This fixes the UT error on my side too.
Not sure why they would only appear "locally", but it works :)


Reply to this email directly or view it on GitHub:
#613 (comment)

@realityking
Copy link
Contributor

The form.php stuff got added with #604.

Update the test to mock the session due to a unit test failure locally, and use getFormToken in the test as well.
@elkuku
Copy link
Contributor

elkuku commented Dec 6, 2011

So, obviously, he's got some super secret squirrelly stuff going on to keep from getting that failure ;-)

This is, honestly, the only reasonable explanation :P
The error also does not appear on the build server but the test gets executed - another JSecret™...

@mbabker
Copy link
Contributor Author

mbabker commented Dec 6, 2011

OK, so I've rebased the branch based on the merge of #604, so now all that's being done here is updating the unit test.

@joomla-jenkins
Copy link

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1876 tests and 11095 assertions.
Checkstyle analysis reported 254 warnings and 0 errors.

@LouisLandry
Copy link
Contributor

Hotness.

LouisLandry added a commit that referenced this pull request Dec 7, 2011
Update JHtmlForm::token() test
@LouisLandry LouisLandry merged commit b5eb8e4 into joomla:staging Dec 7, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants