Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Joomla CMS [#27257] Fix a typo in the publish method of jtablenested.Originally identified i... #680

Merged
merged 4 commits into from
Jan 2, 2012

Conversation

elinw
Copy link
Contributor

@elinw elinw commented Dec 29, 2011

Fix a typo in the publish method of jtablenested.Originally identified in CMS

tracker issue #27257

@joomla-jenkins
Copy link

Unit testing complete. There were 0 failures and 0 errors from 1971 tests and 11142 assertions.
Checkstyle analysis reported 199 warnings and 0 errors.

@@ -974,7 +974,7 @@ public function publish($pks = null, $state = 1, $userId = 0)

// Update and cascade the publishing state.
$query = $this->_db->getQuery(true)->update($this->_db->quoteName($this->_tbl))->set('published = ' . (int) $state)
->where('(lft > ' . (int) $this->lft . ' AND rgt < ' . (int) $this->rgt . ')' . ' OR ' . $k . ' = ' . (int) $pk);
->where('(lft > ' . (int) $node->lft . ' AND rgt < ' . (int) $this->rgt . ')' . ' OR ' . $k . ' = ' . (int) $pk);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch incomplete the second this should be node too.

  •    ->where('(lft > ' . (int) $this->lft . ' AND rgt < ' . (int) $this->rgt . ')' . ' OR ' . $k . ' = ' . (int) $pk);
    
  •    ->where('(lft > ' . (int) $node->lft . ' AND rgt < ' . (int) $node->rgt . ')' . ' OR ' . $k . ' = ' . (int) $pk);
    

(btw. the worst readable coding style. some features are nice to have but should not be used to improve readability and compatibility)

@joomla-jenkins
Copy link

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1971 tests and 11142 assertions.
Checkstyle analysis reported 199 warnings and 0 errors.

@joomla-jenkins
Copy link

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1971 tests and 11142 assertions.
Checkstyle analysis reported 199 warnings and 0 errors.

chdemko added a commit that referenced this pull request Jan 2, 2012
Fix a typo in the publish method of jtablenested.Originally identified i...
@chdemko chdemko merged commit 2396dd9 into joomla:staging Jan 2, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants