This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Fix a few phpmd warnings. #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing complete. There were 0 failures and 0 errors from 1994 tests and 11169 assertions. |
|
If you fix up the checkstyle issue I'll merge this. |
|
I missed that there was one. Fixed. |
|
Build triggered by changes to the head. Unit testing complete. There were 0 failures and 0 errors from 2067 tests and 11356 assertions. |
|
Yay, 7 warnings less. One more when we remove the deprecated method. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.