This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
BUGFIX: discover template install #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lang was used but not set so the template installation failed and the style for the template wasn't created
LouisLandry
added a commit
that referenced
this pull request
Jun 7, 2012
BUGFIX: discover template install
|
This was already set at the beginning of the function. What is the utility of this assignment? |
|
My fault, this is an bug in an older version, already fixed and I didn't check against the last version. But maybe it is better within the if as outside, because we need it only in the "then" path. What is process for such a situation, doing another pull request ? |
|
I've removed the useless code |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lang was used but not set so the template installation failed and the style for the template wasn't created