This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Reduce the use of JBrowser. #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @since 12.2 | ||
| */ | ||
| public function isSSLConnection() |
There was a problem hiding this comment.
I didn't make it static in JApplication to facilitate us eventually moving to JApplicationWeb. and removing JApplication. So I'd be fine doing it here, however I think that's potentially confusing. Maybe we should make it static after dropping JApplication?
|
a static method could always be called using |
|
True. But at least for JApplication I'd prefer people not using it since it will eventually disappear. |
| */ | ||
| public function isSSLConnection() | ||
| { | ||
| JLog::add('JBrowser::isSSLConnection() is deprecated. Use the isSSLConnection method on the application object instead.', JLog::WARNING, 'deprecated'); |
There was a problem hiding this comment.
The line is too long (checkstyle)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that JHtml still depends on JBrowser, we'll need to fix that before we can move JBrowser to legacy.
Legacy unit tests run fine on my local machine.