Deprecate protected underscore methods and vars

[elkuku]

This is a proposal on how to deal with the remaining code style complaints about protected methods and class variables beginning with an underscore, by creating proxies and enclosing the deprecated functions in @codingStandardsIgnoreStart and -End tags.
A much better solution would be, of course, if the methods could just be renamed.

If this makes any sense you might leave this open for a while and I (or others) might fix the remaing 438 warnings ;)

[robschley]

This should log that a deprecated method was called.

[elkuku]

Huh, haven’t thought about it.. So that would be 441 log entries more...

[joomla-jenkins]

The tests completed but there was a problem parsing the report.
Unit testing complete. There were 0 failures and 0 errors from 1685 tests and 10563 assertions.
Checkstyle analysis reported 438 warnings and 0 errors.

[chdemko]

I've proposed another solution for this fix: ignore var/function beginning with _ if they are marked deprecated

See #501

[LouisLandry]

We could always just change protected $_foo to protected $foo and create a public function __get() / __set() that handles the deprecated usage.

[chdemko]

@louis, it will work for instance vars but PHP does not have (yet) __getStatic and __setStatic method to handle class vars

[elkuku]

Christophe, I think you meant #502 ;) very clever 👍

I am going to close this one in favor of your solution.