PostgreSQL driver for Joomla! platform. #532

gpongelli · 2011-11-14T22:16:17Z

This driver implements inherited function from JDatabase class and add some other useful function to be able to use Joomla! on PostgreSQL database.
There is also a class that inherits from JDatabaseQuery to be able to create query object using PostgreSQL dialect.
These two classes are tested by other two classes under "test" folder.

PostgreSQL's added functions:

dropTable, drops given table
getRandom, ge a random number
getStringPositionSQL, returns string's position inside another string
releaseTransactionSavepoint, release given savepoint during transaction
renameTable, rename given table
showTables, lists all table in database
transactionCommit, commit a transaction
transactionRollback, rollback whole transaction or to a savepoint
transactionSavepoint, creates transaction savepoint
transactionStart, starts a transaction

Overridden functions:

connected
escape
fetchArray
fetchAssoc
fetchObject
freeResult
getAffectedRows
getAlterDbCharacterSet
getCollation
getCreateDbQuery
getNumRows
getQuery
getTableColumns
getTableCreate
getTableKeys
getTableList
getVersion
insertid
query
replacePrefix
select
setUTF

PostgreSQL database query added functions:

limit, a possible replace for limit in setQuery
offset, a possible replace for limit in setQuery
forShare, lock table/row during SELECT
forUpdate, lock table/row during SELECT
getInsertTable, used in "indertid()" to retrieve last INSERT INTO's table name
lock, lock given table
noWait, no wait a locked table
returning, an INSERT INTO optional clause to returns last insert id
unlock, unlock tables

elinw · 2011-11-14T22:19:23Z

Thanks Gabriele!

Hackwar · 2011-11-14T22:47:13Z

Looks interesting. I didn't check the functionality extensively, but I noticed three things. The first is, that you have a series of deprecated messages, which you marked with 11.3. As I understood it, the deprecation marking means the version where it is removed, which would be the next release in your case. The second thing is, that it seems as if something went wrong while merging in the media package. There are two files with a few strange lines at the top. The last thing is an added jimport for JLog in JRegistry. I learned that recently, too, that JLog does not get a jimport anymore, since it is loaded in the bootstrap of the framework.

gpongelli · 2011-11-14T22:59:43Z

Hi hackwar, I've erroneously marked as 11.3 because I've done a find&replace all 11.1 that I've had inside my code.
I see that my media package has something wrong, but I've never edit there, only merged from master branch, so I don't know how it was appened. Please tell me which are these files so I can edit them.
For the third thing I've not understood what piece of code you're referring to, please let me know.

Hackwar · 2011-11-14T23:14:27Z

Broken files in media package:
/libraries/joomla/media/image.php
/libraries/joomla/media/imagefilter.php

unnecessary jimport('joomla.log.log'):
/libraries/joomla/registry/format/json.php

joomla-jenkins · 2011-11-15T00:19:27Z

Build triggered by changes to the base.

Test log missing. Tests failed to execute.
Checkstyle analysis reported 241 warnings and 468 errors.

realityking · 2011-11-15T01:09:45Z

libraries/joomla/registry/format/json.php

@@ -53,6 +53,8 @@ class JRegistryFormatJSON extends JRegistryFormat
 			$options = array('processSections' => $options);

 			// Deprecation warning.
+			jimport('joomla.log.log');


Call is not needed because of the autoloader.

elinw · 2011-11-15T02:34:20Z

Hannes deprecation is the release at which deprecation is announced and is a warning that it will be released in the future. That is how we use it thoughout the platform and the CMS.

We learned a long time ago not to predict when things will actually be removed but instead give a warning that removal is coming.

gpongelli · 2011-11-15T06:43:39Z

Commits added to correct highlighted issues.

joomla-jenkins · 2011-11-15T09:19:27Z

Build triggered by changes to the head.

Test log missing. Tests failed to execute.
Checkstyle analysis reported 241 warnings and 468 errors.

realityking · 2011-11-15T10:44:09Z

@elin didn't we just change it a bit back to say the release win we remove stuff and not the release in which it was first deprecated.

realityking · 2011-11-15T10:45:08Z

libraries/joomla/database/table/menutype.php

@@ -11,6 +11,8 @@ defined('JPATH_PLATFORM') or die;

 jimport('joomla.database.table');

+jimport('joomla.database.table');


Sams as line 12, please remove.

realityking · 2011-11-15T10:48:21Z

@gpongelli
When you're trough addressing comments could you rebase this into one commit?

realityking · 2011-11-15T10:50:11Z

Code Style and unit test report: http://elkuku.github.com/pulltester/pulls/532.html

elinw · 2011-11-15T11:56:23Z

Those who forget the past are condemned to repeat it.

gpongelli · 2011-11-15T12:56:28Z

@elin it's really strange, I continuously merge postgresql branch with fetched master branch but some of changes on master branch, not related to postgresql, seems to be lost.

@realityking wow, how can I generate this report, so I can correct all once ?
I'm clearing commented code, next I'll commit on my branch. What do you mean with "rebase this" ? "This" what ?

joomla-jenkins said test log missing, which are those files so I can commit them ?

gpongelli · 2011-11-15T13:14:18Z

@ALL I've added some label used inside errorMsg variable, where can I add english translation of these strings ?
an example is postgresql.php, line 71 .
Thank you!

elinw · 2011-11-15T15:49:10Z

Right now they are still figuring out how to package the strings so in the CMS it will get put into the file what holds all the library strings. Not much else to do about it right now.

realityking · 2011-11-15T15:51:45Z

For the code style stuff phpcs is used (https://github.com/sebastianbergmann/phpcs-sebastian)

As for rebasing, here's dome documentation on it: http://help.github.com/rebase/ But that should be the last thing to do after all is fixed.

Conflicts: libraries/joomla/installer/adapters/module.php libraries/joomla/session/storage/database.php

realityking · 2012-01-27T10:05:04Z

Something went wrong here, this pull contains several commits that are already part of master.

gpongelli · 2012-01-27T11:13:42Z

Whats goes wrong?
Sometimes I merge master into my branch to upgrade my branch with new feature and to not have too many differences between these branches except for postgresql additions.

Eng. Gabriele Pongelli

realityking · 2012-01-27T14:29:08Z

Did you happen to rebase you branch? that may have gone wrong.

Maybe Ian knows a way to fix this, if he don't I suggest creating a patch from this pull request (https://github.com/joomla/joomla-platform/pull/532.patch), applying that to a fresh branch and making a new pull request from the new branch.

gpongelli · 2012-01-27T16:41:24Z

No, I didn't rebase this branch, I've only merged last master changes in this branch without rebasing it.
I've fixed some errors about deprecated methods not removed.

What error do you receive ?
Is a merge error ?

JDatabaseExporterPostgreSqlInspector classes to test exporter class.

retrieving an array of stdClass .

stdClass containing all the columns instead of retrieving only type field.

JDatabaseImporterPostgreSqlInspector classes to test importer class.

- "select" hasn't default parameter value. - "getTableKeys" hasn't double quote around table name for changing primary key query.

gpongelli · 2012-02-21T21:18:00Z

waiting #903 and #906 , maybe I'll create another cleaner pull request.

realityking reviewed Nov 15, 2011
View reviewed changes

gpongelli added 7 commits January 25, 2012 07:55

Fixed getTableKey's query .

0dcd838

Fixed $field parameter.

81663b6

Changed getTableSequences to retrieve more informations.

925173f

Changed @SInCE and sequence exported informations.

c89f4c7

Rework of entire class.

8db148b

Merge branch 'charLengthFix' into postgresql

a740e73

Conflicts: libraries/joomla/installer/adapters/module.php libraries/joomla/session/storage/database.php

Merge branch 'pgExporter' into postgresql

431624b

gpongelli added 14 commits January 27, 2012 17:49

Remove deprecated JDatabase methods.

a90cbc1

Added test for getTableKeys.

cf59fa6

Changed getTableKeys query and its test.

09e3543

Updated exporter class to fit with last changes.

f4768de

Added JDatabaseExporterPostgreSqlTest and

29b4488

JDatabaseExporterPostgreSqlInspector classes to test exporter class.

Added testGetTableSequences test and added testGetTableColumns case

76e9625

retrieving an array of stdClass .

Changed buildXmlStructure to retrieve table's columns as array of

a502fb3

stdClass containing all the columns instead of retrieving only type field.

Query fix.

1d2a12b

Added JDatabaseImporterPostgreSqlTest and

77fc47f

JDatabaseImporterPostgreSqlInspector classes to test importer class.

Style change.

8d1f88e

Style changes.

3d4ffeb

Updated "select", "getTableKeys" and their tests due to last changes.

b4201ae

- "select" hasn't default parameter value. - "getTableKeys" hasn't double quote around table name for changing primary key query.

Refactoring of some functions.

a6637cc

Style fix.

77d2473

gpongelli mentioned this pull request Feb 21, 2012

Reorganized and refactored database package. #906

Merged

gpongelli mentioned this pull request Feb 23, 2012

PostgreSQL driver for Joomla! platform [clean version]. #917

Closed

gpongelli mentioned this pull request Mar 4, 2012

PostgreSQL driver for Joomla! platform [clean version _ v2]. #961

Closed

LouisLandry closed this Mar 5, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PostgreSQL driver for Joomla! platform. #532

PostgreSQL driver for Joomla! platform. #532

gpongelli commented Nov 14, 2011

elinw commented Nov 14, 2011

Hackwar commented Nov 14, 2011

gpongelli commented Nov 14, 2011

Hackwar commented Nov 14, 2011

joomla-jenkins commented Nov 15, 2011

realityking Nov 15, 2011

elinw commented Nov 15, 2011

gpongelli commented Nov 15, 2011

joomla-jenkins commented Nov 15, 2011

realityking commented Nov 15, 2011

realityking Nov 15, 2011

realityking commented Nov 15, 2011

realityking commented Nov 15, 2011

elinw commented Nov 15, 2011

gpongelli commented Nov 15, 2011

gpongelli commented Nov 15, 2011

elinw commented Nov 15, 2011

realityking commented Nov 15, 2011

realityking commented Jan 27, 2012

gpongelli commented Jan 27, 2012

realityking commented Jan 27, 2012

gpongelli commented Jan 27, 2012

gpongelli commented Feb 21, 2012

		@@ -11,6 +11,8 @@ defined('JPATH_PLATFORM') or die;

		jimport('joomla.database.table');

		jimport('joomla.database.table');

PostgreSQL driver for Joomla! platform. #532

PostgreSQL driver for Joomla! platform. #532

Conversation

gpongelli commented Nov 14, 2011

elinw commented Nov 14, 2011

Hackwar commented Nov 14, 2011

gpongelli commented Nov 14, 2011

Hackwar commented Nov 14, 2011

joomla-jenkins commented Nov 15, 2011

realityking Nov 15, 2011

Choose a reason for hiding this comment

elinw commented Nov 15, 2011

gpongelli commented Nov 15, 2011

joomla-jenkins commented Nov 15, 2011

realityking commented Nov 15, 2011

realityking Nov 15, 2011

Choose a reason for hiding this comment

realityking commented Nov 15, 2011

realityking commented Nov 15, 2011

elinw commented Nov 15, 2011

gpongelli commented Nov 15, 2011

gpongelli commented Nov 15, 2011

elinw commented Nov 15, 2011

realityking commented Nov 15, 2011

realityking commented Jan 27, 2012

gpongelli commented Jan 27, 2012

realityking commented Jan 27, 2012

gpongelli commented Jan 27, 2012

gpongelli commented Feb 21, 2012