Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Update PHPMailer to version 5.2.1. #848

Merged
merged 1 commit into from Feb 10, 2012
Merged

Conversation

realityking
Copy link
Contributor

No description provided.

@@ -53,7 +53,7 @@ class PHPMailer {
* Sets the CharSet of the message.
* @var string
*/
public $CharSet = 'utf-8';
public $CharSet = 'iso-8859-1';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain utf-8 (I know iso-8859-1 is PHPMailer's default); at least that's how we've used it for quite some time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with @mbabker : since we use the JMail class, we only have to declare

public $CharSet = 'utf-8';

in our JMail class and leave PHPMailer unchanged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I ended up changing it when I did the 5.2 update, so if that works better, I'm all for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@chdemko
Copy link
Contributor

chdemko commented Feb 9, 2012

BTW, we have to upgrade to mootools 1.4.4 and to simplepie 1.2.1

@realityking
Copy link
Contributor Author

I have MooTools high on my list, I wanna do the update together with the dropping of the 1.2 compatibility layer.

As for simplepie, can't we just remove it from the platform? We don't really use it but for one method in the factory, I'd just leave it up to the CMS to include it.

@joomla-jenkins
Copy link

Unit testing complete. There were 0 failures and 0 errors from 1994 tests and 11169 assertions.
Checkstyle analysis reported 165 warnings and 0 errors.

chdemko added a commit that referenced this pull request Feb 10, 2012
Update PHPMailer to version 5.2.1.
@chdemko chdemko merged commit 9c68148 into joomla:staging Feb 10, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants