[5.0] sort deleteFiles in update script #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @heelc29 wir können die Einträge nicht löschen, da wir nicht davon ausgehen können das ein Update von de-DE gemacht worden ist. Der Core kann die Dateien löschen da es da ja garantiert ist das die script.php gelaufen ist wir können das aber nicht. Ich würde hier vorschlagen in der script.php in dem array einen Kommentar zu schreiben der auf die alten Joomla 3 sprachdateien hinweist. |
heelc29
force-pushed
the
5.0/script/cleanup
branch
from
306551e
to
630c2e8
Compare
heelc29
changed the title
@zero-24 erledigt |
tecpromotion
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zusammenfassung der Änderungen
> Clear the lists of deleted files and folders and renamed files in script.php by old entries for updating from 3 to 4.joomla/joomla-cms#40083gelöschte Dateien nach Joomla-Version in script.php sortiert
Wo wird der Sprachstring angezeigt / Wie kann getestet werden
code review