Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire upgrade if extension is already registered #23

Closed
stevenrombauts opened this issue Mar 4, 2016 · 2 comments
Closed

Fire upgrade if extension is already registered #23

stevenrombauts opened this issue Mar 4, 2016 · 2 comments
Milestone

Comments

@stevenrombauts
Copy link
Member

Consider the following scenario:

  • Website is being deployed using a tool such as Capistrano
  • The database already has the extension schema applied and is registered in assets/extensions tables
  • A new deployment triggers composer install, which will try to re-install those extensions
  • Errors will be thrown because the extension schema is already applied

To solve this :

  • After downloading of the files by Composer, check if the extension is already installed yes or no by looking at the database
  • If not installed, run install(), otherwise run update()
@stevenrombauts stevenrombauts added this to the Backlog milestone Mar 4, 2016
@stevenrombauts stevenrombauts changed the title Fire upgrade if extension is already in the database Fire upgrade if extension is already registered Mar 4, 2016
@stevenrombauts
Copy link
Member Author

stevenrombauts commented Apr 12, 2016

The JInstallerAdapterComponent::update() method fails when trying to update if the extensions' code is missing because it tries to look for the old manifest. See: https://github.com/joomlatools/joomlatools-platform/blob/f821f3fb87d7101670bb309f17a43ac127ead5f1/lib/libraries/cms/installer/adapter/component.php#L632-L650

This needs to be fixed in platform first.

@johanjanssens
Copy link
Member

@stevenrombauts You need any help on this in the platform ?

@johanjanssens johanjanssens modified the milestones: 1.2, Backlog Apr 20, 2017
stevenrombauts pushed a commit that referenced this issue Oct 2, 2018
Joomla installer needs to be able to find these
manifests in the root directory or first sublevel
down.
stevenrombauts pushed a commit that referenced this issue Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants