Get tag for language type fixed #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @soxyl, we're always happy to hear our tools could help you solve some of your problems! Thanks for this PR, tested it and it looks good. Will roll this out it a patch release right now. |
stevenrombauts
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all I'd like to thank you all for the great Composer extension you created here. After investing a lot of time in automatizing our setup, this extension solved most of the problems we were facing. 馃憤
Our application is multi language and while trying to install Joomla language packages the process failed.
After some debugging I was able to fix the issue with the following change. Since then the installation works without any problems.