Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI wrapper class refactor #49

Closed
4 tasks done
ercanozkaya opened this issue Nov 2, 2016 · 1 comment
Closed
4 tasks done

UI wrapper class refactor #49

ercanozkaya opened this issue Nov 2, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@ercanozkaya
Copy link
Member

ercanozkaya commented Nov 2, 2016

  • Add Joomla page suffix class to the wrapper in ComKoowaTemplateHelperUi
  • Rename koowa to k-ui-namespace
  • Make sure k-ui-namespace can be used on any element.
  • Rename koowa-container to k-ui-container

See: https://support.joomlatools.com/forums/topic/6689#comment-35918

@ercanozkaya ercanozkaya added this to the 3.0.0 milestone Nov 2, 2016
robinpoort pushed a commit that referenced this issue Nov 21, 2016
Refactor .koowa to .k-ui-namespace and .koowa-container to .k-ui-container
robinpoort pushed a commit that referenced this issue Nov 21, 2016
Refactor .koowa to .k-ui-namespace and .koowa-container to .k-ui-container
robinpoort pushed a commit that referenced this issue Nov 21, 2016
@robinpoort
Copy link
Contributor

@ercanozkaya I did the work in branches in the repositories you can see referenced above.

I didn't touch joomlatools-todo yet. We can do that in one go when finishing up the UI there. See: joomlatools/joomlatools-todo#11

I've looked through the entire codebase and changed every koowa instance I was sure of that it'd was there for the namespace purpose. I think it'd be wise if you could thoroughly look through the changes and check the repositories to see if I missed stuff.

I wasn't sure about the following koowa instances:

  • joomlatools-framework/autoload.php:36
  • joomlatools-framework/code/libraries/joomlatools/component/koowa/dispatcher/response/transport/http.php:34
  • joomlatools-framework/code/libraries/joomlatools/component/koowa/dispatcher/response/transport/http.php:38
  • joomlatools-framework/code/libraries/joomlatools/component/koowa/template/filter/version.php:97
  • joomlatools-framework/code/libraries/joomlatools/library/class/registry/cache.php:23
  • joomlatools-framework/code/libraries/joomlatools/library/filesystem/stream/factory.php:60
  • joomlatools-framework/code/libraries/joomlatools/library/object/locator/abstract.php:70
  • joomlatools-framework/code/libraries/joomlatools/library/object/manager/manager.php:104
  • joomlatools-framework/code/libraries/joomlatools/library/object/registry/cache.php:23
  • joomlatools-framework/code/libraries/joomlatools/library/template/cache.php:23
  • joomlatools-framework/code/libraries/joomlatools/library/template/template.php:88
  • joomlatools-framework/code/libraries/joomlatools/library/user/session/abstract.php:136
  • joomlatools-framework/code/plugins/system/joomlatools/joomlatools.php:123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants