Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow page() method to return active entity #38

Closed
johanjanssens opened this issue Dec 29, 2018 · 0 comments
Closed

Allow page() method to return active entity #38

johanjanssens opened this issue Dec 29, 2018 · 0 comments
Assignees
@johanjanssens
Labels
feature
Milestone
v0.4.0

Comments

@johanjanssens
Copy link
Member

johanjanssens commented Dec 29, 2018 •
edited

Refactor the page() methods to return the active entity if no path parameter is passed.
@johanjanssens johanjanssens added this to the 0.4.0 milestone Dec 29, 2018
@johanjanssens johanjanssens self-assigned this Dec 29, 2018
@johanjanssens johanjanssens changed the title Allow page() method to return active entity Allow page() and pages() method to return active entity Dec 29, 2018
@johanjanssens johanjanssens changed the title Allow page() and pages() method to return active entity Allow page() method to return active entity Dec 29, 2018
johanjanssens added a commit that referenced this issue Dec 29, 2018
@johanjanssens
#38 - Code cleanup
8f9f23f
johanjanssens added a commit that referenced this issue Dec 29, 2018
@johanjanssens
#38 - Add 'text' page property
9ae12c3
johanjanssens added a commit that referenced this issue Dec 29, 2018
@johanjanssens
#38 - Do not try to pre-render a page in the registry
d915b1d
johanjanssens added a commit that referenced this issue Dec 29, 2018
@johanjanssens
#38 - Fix typo
6f304b4
johanjanssens added a commit that referenced this issue Dec 29, 2018
@johanjanssens
#38 - Code cleanup
e227ccd
johanjanssens added a commit that referenced this issue Dec 29, 2018
@johanjanssens
#38 - Refactor page() method
645dda0 
- Move page() and pages() template methods to ComPagesViewHtml
- Make page() return the active page object (similar to url())
- Consolidate template logic in ComPagesTemplateDefault and remove specialised page and layout templates
- Add ComPagesTemplateDefault::addFilters() method
- Remove ComPagesTemplateDefault::route() method
- Remove ComPagesViewBehaviorRoutable
@johanjanssens johanjanssens mentioned this issue Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanjanssens johanjanssens

Labels
feature
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@johanjanssens