Make ComPagesTemplateHelperBehavior::isLoaded() smart #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Do not include og metadata if og:typeis nullor false - Allow robots to be defined a single value string, eg robots: none
If a page object exists, set the data in it, if not set the object.
Check if path exists before calculating hash
Sync with changes in framework 3.4.13
Update dependencies to Joomlatools Framework v3.4.13
Use class for toc
Webservice collection cache_path config option
Allow calling template functions directly
Update highlight.php to v9.18.1.6
Remove anchorjs in toc filter
Following: https://www.a11ymatters.com/pattern/pagination/ - Use nav element with aria-label="pagination" - Add aria-label to each link - Mark active page with aria-current="page"
Added new metadata() and canonical() template functions
Improve pagination
Add first and last pagination buttons, but hide them by default.
Template cache no longer working
Canonical url is not correct
- Add `getCachePath()` method to ComPagesConfig` - Rename `http_resource_cache` to `http_client_cache - Rename `http_resource_cache_path` to http_client_cache_path` - Rename `http_resource_cache_debug` to `http_client_cache_debug` - Rename http client cache file prefix from `resource` to `response
Improve cache location handling
- Retrieve the method name from the callstack if no key provided - Automatically setLoaded()
johanjanssens
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #649