Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-location not correct #832

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Content-location not correct #832

merged 1 commit into from
Dec 3, 2021

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 3, 2021

This PR Closes #831 and fixes and issue with the Content-Location not being correct when random query parameters are added to the url for collection pages.

The Content-Location is used to generate the cache key and by including random query parameters that cache can be busted which is not ideal.

A state should always be correctly defined. Use the filter[] state instead
to apply custom filtering.
@github-actions github-actions bot added the bug Something isn't working label Dec 3, 2021
@johanjanssens johanjanssens merged commit 3eb04c7 into master Dec 3, 2021
@johanjanssens johanjanssens deleted the feature/831-location branch December 3, 2021 18:49
@johanjanssens johanjanssens added this to In progress in v0.22.2 via automation Dec 3, 2021
This was referenced Dec 3, 2021
@johanjanssens johanjanssens added this to the v0.22.2 milestone Dec 4, 2021
@johanjanssens johanjanssens moved this from In progress to Ready in v0.22.2 Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v0.22.2
  
Ready
Development

Successfully merging this pull request may close these issues.

Content-location not correct
1 participant