Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cache for json to be explicitly enabled #903

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jun 27, 2022

This PR Closes #902 and changes the caching logic for json output. Caching for json now needs to be explicitly enabled in the page frontmatter by setting:

@process:
    cache: true

Other

This PR also fixes a bug in the cache validation logic. The fix ensures that if the cache validators contain a page that no longer exists the cache is always invalidated.

@github-actions github-actions bot added the bug Something isn't working label Jun 27, 2022
@johanjanssens johanjanssens added this to In progress in v0.23.0 via automation Jun 27, 2022
@johanjanssens johanjanssens merged commit 06f0529 into master Jun 27, 2022
v0.23.0 automation moved this from In progress to Ready Jun 27, 2022
@johanjanssens johanjanssens deleted the feature/902-cache branch June 27, 2022 21:25
@johanjanssens johanjanssens added refactor breaking This issue contains a BC breaking change and removed bug Something isn't working labels Jun 27, 2022
@johanjanssens johanjanssens changed the title Harden cache validation Require cache for json to be explicitly enabled Jun 27, 2022
johanjanssens added a commit that referenced this pull request Jul 27, 2022
johanjanssens added a commit that referenced this pull request Jul 31, 2022
@johanjanssens johanjanssens added this to the v0.23.0 milestone Aug 8, 2022
@johanjanssens johanjanssens mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This issue contains a BC breaking change refactor
Projects
No open projects
v0.23.0
  
Ready
Development

Successfully merging this pull request may close these issues.

Require cache for json to be explicitly enabled
1 participant