Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add limit/offset if collection is not paginatable #923

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jul 3, 2022

This PR Closes #922 and improves the jsonapi output only adding limit/offset metadata if the collection is paginatable

@github-actions github-actions bot added bug Something isn't working refactor labels Jul 3, 2022
@johanjanssens johanjanssens added this to In progress in v0.23.0 via automation Jul 3, 2022
@johanjanssens johanjanssens merged commit cc6a0a1 into master Jul 3, 2022
v0.23.0 automation moved this from In progress to Ready Jul 3, 2022
@johanjanssens johanjanssens deleted the feature/922-jsonapi branch July 3, 2022 22:08
@johanjanssens johanjanssens added this to the v0.23.0 milestone Aug 8, 2022
@johanjanssens johanjanssens mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
No open projects
v0.23.0
  
Ready
Development

Successfully merging this pull request may close these issues.

Do not add limit/offset if collection is not paginatable
1 participant