Improve image filter attribute handling #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Rename <ktml:images> to <ktml:image> - Allow to set custom data- attributes on <img /> elements - Remove ability to set img filter config options using data- attributes, should use <ktml:image> instead
github-actions
bot
added
breaking
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes #944 and refactors the image filter as part of #812
Following changes have been made:
<ktml:images></ktml:images>has been renamed to<ktml:image></ktml:image>The image filter now allows to add custom
data-attributes to image elements and they are re-included when the<img />element is replaced with a responsive version.It's no longer possible to use
data-attributes to provide filter config options, instead a<ktml:image></ktml:image>wrapper should be used. For example: