Out-Default function breaks $?

[chenxiaolong]

The definition of Out-Default seems to be breaking the usage of $?.

For example, if I run an invalid command in pwsh -noprofile, I get this:

PS C:\Users\chenxiaolong> git asdf
git: 'asdf' is not a git command. See 'git --help'.

The most similar command is
        add
PS C:\Users\chenxiaolong> echo $?
False

If I import Get-ChildItemColor (version 2.1.1), then $? stops working properly:

PS C:\Users\chenxiaolong> Import-Module Get-ChildItemColor
PS C:\Users\chenxiaolong> git asdf
git: 'asdf' is not a git command. See 'git --help'.

The most similar command is
        add
PS C:\Users\chenxiaolong> echo $?
True

If I remove the Out-Default function, then things work again, but of course, no more ls colors:

PS C:\Users\chenxiaolong> Remove-Item Function:Out-Default
PS C:\Users\chenxiaolong> git asdf
git: 'asdf' is not a git command. See 'git --help'.

The most similar command is
        add
PS C:\Users\chenxiaolong> echo $?
False

[schmjop]

I have the same issue unfortunately. @joonro is there as possible workaround?

[vdsbenoit]

I think it is related to an issue in PSColor, which Get-ChildItemColor relies on. Both projects seem to be unmaintained so I don't think this issue is going to be resolved anytime soon.

[joonro]

Hi, sorry for the late response. I'm glad to let you know that I was able to fix this issue (d651f92). Now this module no longer overloads Out-Default --- instead, users should use Get-ChildItemColor. The function is now pipeline-aware (i.e., it does not touch the output when used as a part of a pipeline) and I think it should be more robust. Please let me know if this works for you.

[joonro]

I will close this as this should be resolved in the latest version. Please feel free to open it again if there is still an issue.

[vdsbenoit]

I confirm it's fixed on my side too! Thank you so much

[joonro]

Great! Sorry it took so long to fix, but better late than never I guess :)

[vdsbenoit]

Sure! Thank you for maintaining this project, which is quite handy