Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15 - Support inline comments #20

Merged
merged 4 commits into from
Apr 20, 2018

Conversation

randallreedjr
Copy link
Contributor

@randallreedjr randallreedjr commented Feb 23, 2017

This pull request implements fixes for three issues:

Issue #15 - Continue parsing after a line with an inline comment (@bsedat's fix), now with a passing build
Issue #19 - Replace link with updated documentation
Issue #21 - Set codeclimate-test-reporter version in Gemfile to avoid breaking changes in 1.0.0

@randallreedjr randallreedjr changed the title Bug/inline comments Fixes #15 - Support inline comments Feb 23, 2017
@randallreedjr
Copy link
Contributor Author

@joonty I would love to get this merged in as soon as possible! Please let me know if I missed anything regarding contribution guidelines.

@randallreedjr
Copy link
Contributor Author

@joonty Anything I can do to help get this merged in? Thanks!

@randallreedjr
Copy link
Contributor Author

@joonty Just a reminder to check out this pull request. :)

@jleo3
Copy link
Contributor

jleo3 commented Mar 17, 2017

💯 I would love to see this change incorporated into the next release!

@taylorthurlow
Copy link

I too would like to see this merged.

I'm not sure if it's my inexperience showing or not, but I couldn't for the life of me figure out how to clone this repo with this pull request and use it on my gemfile, so I forked the gem and applied this patch. Repo is here.

@randallreedjr
Copy link
Contributor Author

@joonty I'd be happy to help manage this repo. Would you be open to adding me as a collaborator?

@joonty
Copy link
Owner

joonty commented Apr 10, 2018

Sorry everyone. Life (kids!) has taken over a bit!

I'm going to block in some time to work on pessimize, so I'll check this over properly. Sorry for the long wait.

@randallreedjr
Copy link
Contributor Author

@joonty No worries! We all know how that goes.

@joonty
Copy link
Owner

joonty commented Apr 20, 2018

Thanks @randallreedjr and @bsedat for your work! I've tried this out and it all works well. I'll get this version released to rubygems.org.

@joonty joonty merged commit 33a7a70 into joonty:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants