Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove old breakpoint from an empty line. #292

Closed
Roy-Orbison opened this issue Jun 9, 2017 · 6 comments
Closed

Cannot remove old breakpoint from an empty line. #292

Roy-Orbison opened this issue Jun 9, 2017 · 6 comments

Comments

@Roy-Orbison
Copy link
Contributor

Get this error message: Cannot set a breakpoint on an empty line
Toggling should always allow removal based on line's sign, only chucking an error if one's trying to add to an empty line.

Also consider emulating browser debuggers which add a marker to the next available non-empty line. If you're feeling really fancy, "animate" another sign type (so as not to affect actual breakpoint signs) with the same sign style, down to that line by progressively toggling it on and off preceding lines.

@webastien
Copy link

not solving the problem but if you need to remove an old breakpoint which cannot be done by the command or shortcut, you can type BreakpointRemove ID (use BreakpointWindow to get the ID).

@Roy-Orbison
Copy link
Contributor Author

Roy-Orbison commented Jul 22, 2017 via email

@mortona42
Copy link

+1 for this issue. I'd like to see invalid breakpoints removed automatically, if possible.

Roy, are you saying if you put a breakpoint on an invalid line (like a multi-line array definition), it should automatically be placed on the right line? If so, that sounds awesome. There have been many times I thought I set a valid breakpoint, only to realize it didn't work as expected.

@Roy-Orbison
Copy link
Contributor Author

@mortona42 That, too. It should only add to the next breakable line.

@Taluu
Copy link

Taluu commented Aug 29, 2017

Found that. Also useful for when a breakpoint does not want to be removed
even though it's on a code line.

It's when you add another line of code before the breakpoint line. Adding a line before said breakpoint should imo either shift the breakpoint (best UX solution imo) or delete it automatically...

@Roy-Orbison
Copy link
Contributor Author

Thanks @Taluu, I now see what line breakpoints are actually on, from the :BreakkpointWindow, and toggling it on the listed line removes the erroneous mark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants