Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not normalize an implausible phone #16

Merged
merged 1 commit into from Feb 1, 2013
Merged

Do not normalize an implausible phone #16

merged 1 commit into from Feb 1, 2013

Conversation

Jell
Copy link
Contributor

@Jell Jell commented Feb 1, 2013

It can generate an unexpected string. Example:

Phony.normalize("01")
=> "1[#<Phony::NationalCode:0x007fc0745223a8 @national_splitter=#<Phony::NationalSplitters::Fixed:0x007fc074522448 @size=3, @zero=nil>, @local_splitter=#<Phony::LocalSplitters::Fixed:0x007fc07442d790 @format=[3, 14]>, @normalize=true>]"

@joost
Copy link
Owner

joost commented Feb 1, 2013

Related to Phony issue: floere/phony#51

joost pushed a commit that referenced this pull request Feb 1, 2013
Merge pull request #16 from PugglePay/master
8796c35 
Do not normalize an implausible phone (by checking Phony.plausible?(number)).
@joost joost merged commit 8796c35 into joost:master Feb 1, 2013
@joost
Copy link
Owner

joost commented Feb 1, 2013

I will bump the version to 0.1.13 when rubygems is back up.

@Jell
Copy link
Contributor Author

Jell commented Feb 1, 2013

Ha! Right! I didn't notice it was you on the Phony issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jell @joost