Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby versions and Relax dependancies #192

Merged
merged 5 commits into from Mar 18, 2019

Conversation

berkos
Copy link
Contributor

@berkos berkos commented Mar 16, 2019

馃憢

  • Upgrade to latest Rubies on Travis.
  • Remove Gemfile.lock to relax dependancies between different Ruby versions.
  • Fix offences in latest Rubocop. (Should the version of rubocop locked?)

note: Gemfile.lock is bundled with a specific version of bundler, not sure if there is a reason to keep the lock file as versions can locked from gemspec.

Thanks!

@berkos berkos changed the title Upgrade Ruby versions Upgrade Ruby versions and Relax dependancies Mar 16, 2019
@coveralls
Copy link

coveralls commented Mar 16, 2019

Coverage Status

Coverage decreased (-0.0006%) to 99.825% when pulling 572a552 on berkos:upgrade_Ruby_versions_on_travis into 22d06c8 on joost:master.

@joost joost merged commit 12a6cb3 into joost:master Mar 18, 2019
@joost
Copy link
Owner

joost commented Mar 18, 2019

Thanks. Useful changes.

@berkos
Copy link
Contributor Author

berkos commented Mar 18, 2019

Thanks for the response and merging the PR.
If we find that Rubocop keeps finding new offences when updates to the latest version we could lock Rubocop version as development dependancy.

@berkos berkos deleted the upgrade_Ruby_versions_on_travis branch March 18, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants