Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no returned states in request #50

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Fix no returned states in request #50

merged 2 commits into from
Jun 9, 2023

Conversation

joostlek
Copy link
Owner

@joostlek joostlek commented Jun 9, 2023

Proposed Changes

Apparently OpenSky returns { "states": null, "time": 1683488744 } when no states have been found instead of an empty array. This PR handles this and returns an empty list. Fixes #49

Related Issues

(Github link to related issues or pull requests)

@joostlek joostlek added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #50 (7e16f1e) into main (2b005da) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7e16f1e differs from pull request most recent head 2536de7. Consider uploading reports for the commit 2536de7 to get more accurate results

@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          209       211    +2     
  Branches        18        19    +1     
=========================================
+ Hits           209       211    +2     
Impacted Files Coverage Δ
src/python_opensky/opensky.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@joostlek joostlek merged commit 9df798f into main Jun 9, 2023
24 checks passed
@joostlek joostlek deleted the fix_no_state_request branch June 9, 2023 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opensky sensor not working
1 participant