Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom keybindings for euporie.notebook.tabs.notebook.Notebook are not detected #107

Closed
matheusfillipe opened this issue Apr 27, 2024 · 0 comments · Fixed by #108
Closed

Comments

@matheusfillipe
Copy link
Contributor

matheusfillipe commented Apr 27, 2024

Keybindings customizations work for euporie.core.app.BaseApp but not for euporie.notebook.tabs.notebook.Notebook.

Steps to reproduce

Install euporie with pipx:

pipx install euporie

Create and edit config.json accordingly to documentation setting custom values in euporie.notebook.tabs.notebook.Notebook

{
  "edit_mode": "vi",
  "notebook": {
    "line_numbers": true,
    "run_after_external_edit": false,
    "expand": true,
    "show_cell_borders": true,
    "show_side_bar": true,
    "always_show_tab_bar": false,
    "multiplexer_passthrough": true,
    "color_scheme": "default"
  },
  "key_bindings": {
    "euporie.core.app.BaseApp": {
      "next-tab": "A-]",
      "previous-tab": "A-["
    },
    "euporie.notebook.tabs.notebook.Notebook": {
      "copy-cells": "y",
      "cells-to-code": "c"
    }
  }
}

Outcome

I can switch tabs with Alt-] and Alt-[ but I cannot copy cells with y or convert cells to code with c.

The app menus still show the old shortcuts for these actions:
image

But show the new and they are function for the other ones:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant