Feat: implement calculator into unit converter & unit calculate methods #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbrauer
changed the title
This was referenced Nov 13, 2017
Closed
jordanbrauer
added a commit
that referenced
this pull request
Nov 13, 2017
* Update: changelog config file & composer script * Feat: add explicit calculator classes to handle all math related operations (#52) * Update: remove redundant import * Feat: add abstract calculator class interface * Feat: add simple calculator concrete class & write tests * Feat: add binary calculator (bcmath) concrete class & write tests * Feat: implement calculator into unit converter & unit calculate methods (#53) * Fix: simplecalc bugs * Feat: add new exceptin for missing calculator * Fix: tests to use new calculator * Fix: example file to use new calculator * Feat: implement the calculator into the unit converter * Update: scripts * Update: readme to reflect new api * Fix: formatting & docblocks * Update: add codeclimate config & travis script updates * Update: Add codeclimate badges: * Fix: unit test missing @Covers & @uses docblock annotations * Update: coverage scripts * Update: add missing Code Climate YAML config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
The
BinaryCalculator(bcmath) won't work quite yet, as it require it's arguments to be strings. To do this, I imagine we can cast our hard-coded parameters to strings if the currently active calculator is theBinaryCalculator