Hash eq board #45
Merged
Hash eq board #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The phrasing of the title is to get a common phrase into the commit log.
5 tasks
|
I'll look over this tonight I think. Nothing looks crazy to me off hand. There's no reason to believe hashing the hash is going to be a problem, other than a performance hit. I do wish there was a better way, but I don't know of one off-hand. |
|
@jordanbray Are there any comments from your review that I should implement? |
|
Sorry for the delay. This all looks good to me. I ran some performance tests just to be sure nothing funky happened, and it didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #44
This PR makes
Boardpossible to use as the key of a standard RustHashMap.Most of the changes are additions to
#[derive]attribute for the types.Of note is the
impl Hash for Board. Thehashfunction does not return its result and instead has a&mut Hasherparameter to hold the state of the hash. The current solution is to only hashself.hash. This is faster than the#[derive], as it is only one field, but I do not know the implications of using a hash of a hash.