Support multiValueHeaders on Response #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jordaneremieff
I suggest to support
multiValueHeaders
on Response.I want to set the same-name cookies.
FastAPI
+uvicorn
can return same-name cookies.But, Mangum returned only the last cookie. the first cookie is dropped.
Mangum should support
multiValueHeaders
to resolve the problem.This change affects a little bit of performance.
If You prefer this PR, then I will add test the code.
How do you think about it?
https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-output-format
example
output