Removing Websocket from docs #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aminalaee yep, these references should be removed. Thanks. |
|
There's only one mention of Websocket in |
|
Did support for websocket end in another repository? |
vitorcarareto
added a commit
to vitorcarareto/mangum
that referenced
this pull request
Jan 18, 2023
This reverts commit 88ae4d9.
|
Does latest version still have websocket support? i still see mentioning about websocket. |
khamaileon
pushed a commit
to khamaileon/mangum
that referenced
this pull request
Jan 13, 2024
* Removing Websocket from docs * Update lifespan.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Websocket support was removed in latest version but it's still mentioned in README and the docs. Should it be removed?
This is just a sample, there are other references to Websocket support.