Skip to content

Commit

Permalink
do not include epoch version in generate .deb filenames
Browse files Browse the repository at this point in the history
  • Loading branch information
@tmm1
tmm1 committed Jul 8, 2011
1 parent a648617 commit dee3ddc
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions lib/fpm/target/deb.rb
View file
Expand Up @@ -97,12 +97,10 @@ def build!(params)
end # def build

def default_output
v = version
v = "#{epoch}:#{v}" if epoch
if iteration
"#{name}_#{v}-#{iteration}_#{architecture}.#{type}"
"#{name}_#{version}-#{iteration}_#{architecture}.#{type}"
else
"#{name}_#{v}_#{architecture}.#{type}"
"#{name}_#{version}_#{architecture}.#{type}"
end
end # def default_output

Expand Down

6 comments on commit dee3ddc

@mblair
Copy link
Contributor

@mblair mblair commented on dee3ddc Mar 7, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made? I have an epoch use case. At the moment I have to use -p :-/

http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version

@jordansissel
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen any debian package 'file names' that include the epoch. Apt-get also doesn't handle things well, it converts ":" in the filenames to %58 url-style encoding. Much confusings occur.

If you can show me a few debian packages with the epoch in the filename, we can revert this change or alternately make it a flag.

@mblair
Copy link
Contributor

@mblair mblair commented on dee3ddc Mar 7, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was mistaken. The Version control field contains the epoch, it just differs from the filename (and that's just fine).

For others who stumble upon this:

http://www.debian.org/doc/manuals/debian-faq/ch-pkg_basics.en.html#s-pkgname

Thanks!

@jordansissel
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, actually, you uncover a good point.

The output from fpm only shows you the filename. Perhaps it should show some data as well?

Created whatever.deb
name: blah
version: blah
....

@mblair
Copy link
Contributor

@mblair mblair commented on dee3ddc Mar 7, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. It looks like you're already tracking this:

#105

@mblair
Copy link
Contributor

@mblair mblair commented on dee3ddc Mar 8, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight update:

APT (says it) grabs debs with an epoch in the filename, whether or not it's actually doing so:

rcrowley/freight#21

Please sign in to comment.