New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--config-files should recurse if argument is a directory #171
Comments
+1 for that. I wanted to have this for quite some time, as adding multiple --config-files can be annoying :) |
Actually, do you plan this for 0.4.x or still for 0.3.x? |
0.3.x will not receive any further updates from me :) |
Um, harsh :) |
But right now that's not true:
|
I never had issues with this, provided that "conffiles" has fully-qualified path to each file, and there is one file per line. This means that you have to use --config-files for each file separately (the recursive nature of --config-files is not yet there as far as I can tell). You can extract relevant bits of your .deb file and see what is inside "conffiles" and whether it has expected paths: ar p trafficserver-3.2.3-0_amd64.deb control.tar.gz | tar zxf - -O conffiles You should see content of the "conffiles" on the console, and it should have one file per line that has fully-qualified path. |
This is a bit dangerous as-is. I've come to rely heavily on fpm, it's a great tool - but the documentation regarding --config-files is totally incorrect, it does not recursively mark the contents of a directory as conffiles. This could cause some quite serious destruction - a deb built with fpm will overwrite customised config files with the "standard" ones included in the package, as if they were standard files. Anyone without a backup of their original files will have to go back to square 1 and recreate the contents of their config files. I know a massive amount of work has gone into fpm, and it's a brilliant tool, but I think the documentation should be updated asap - people using the tool may be heading for a nasty surprise. (just saw it's a wiki - with your permission I'll update it...) Thanks, James |
@j4m3s sorry, this area doesn't have much testing because I never put any config files in any packages at all. I'll try to add tests to cover this area soon. With respect to the --help output, I've updated master to not claim directory recursion in --config-files |
Wow that is staggeringly responsive! I tried all sorts so have tested that there is no way you can specify a directory and have it expanded to individual conffiles :) Congratulations on such a useful bit of software, I couldn't do without it now. |
I'll add recursion soon (and will close this bug when it's committed/tested), sorry again for the confusion :) |
I usually just use a find on the directory. Jordan Sissel notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
Closes #171 --config-files should recurse if argument is a directory
Closes jordansissel#171 --config-files should recurse if argument is a directory
Closes jordansissel#171 --config-files should recurse if argument is a directory
Closes #171 --config-files should recurse if argument is a directory
Closes #171 --config-files should recurse if argument is a directory
It should be as easy as
--config-files etc/myproject
The text was updated successfully, but these errors were encountered: