Add trusted-host option for pip #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIKS this parameter can hold (just) 1 host? |
|
@BartKoppers Good insight. I think this code could be easily updated to allow multiple hosts without harming usability -- but I think we can wait until that is requested. Patch looks OK to me :) |
jordansissel
approved these changes
Jan 19, 2021
| want_pkg, | ||
| ] | ||
|
|
||
| safesystem(setup_cmd*" ") |
There was a problem hiding this comment.
safesystem() can take a list of arguments, so I'll make a small change after merging to use it that way.
jordansissel
added a commit
that referenced
this pull request
Jan 19, 2021
instead of a space-separated argument string
Tested with this command:
bundle exec bin/fpm --debug -s python -t deb --python-pip =pip django
And verified that safesystem() to invoke pip is given a list.
Mentioned this here:
#1737 (comment)
jordansissel
added a commit
that referenced
this pull request
Jan 19, 2021
instead of a space-separated argument string
Tested with this command:
bundle exec bin/fpm --debug -s python -t deb --python-pip =pip django
And verified that safesystem() to invoke pip is given a list.
Mentioned this here:
#1737 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes private devpi registry doesn't have a valid ssl-certificate, so pip is unable to install something from it. This patch adds option "--trusted-host" which allows work with unsecure devpi registies.