Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in execmd: stdin_w_close -> stdin_w.close #1948

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fixed bug in execmd: stdin_w_close -> stdin_w.close #1948

merged 1 commit into from
Oct 31, 2022

Conversation

NicholasBHubbard
Copy link
Contributor

I believe you meant stdin_w.close but accidentally typed stdin_w_close in the execmd method.

@NicholasBHubbard NicholasBHubbard marked this pull request as ready for review October 31, 2022 00:21
@jordansissel
Copy link
Owner

Nice catch. I think this bug went unnoticed because this statement is never executed. The only place I could find a execmd used with a block is in the python.rb which closes stdin itself.

@jordansissel jordansissel merged commit 56a97c4 into jordansissel:main Oct 31, 2022
@NicholasBHubbard NicholasBHubbard deleted the fix-execmd-typo branch October 31, 2022 22:20
@wbraswell
Copy link
Contributor

Great work, everybody! :-)

@jordansissel
Copy link
Owner

fpm 1.15.0 is released and contains this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NicholasBHubbard @jordansissel @wbraswell